Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy field values from other sites #14056

Open
wants to merge 107 commits into
base: 5.6
Choose a base branch
from
Open

Copy field values from other sites #14056

wants to merge 107 commits into from

Conversation

brianjhanson
Copy link
Contributor

@brianjhanson brianjhanson commented Dec 18, 2023 •
edited
Loading

Continuation of #12436 but instead of handling the copy server-side, the controller will return fragments of HTML that we use to replace fields and immediately save a draft. This simplifies the logic a bit as we can rely on existing "Save Draft" processes to save the values.

Description

On the entry/category edit page (elements that support autosaving drafts):

  • Added an item to the action menu that allows you to copy all, translatable, changed values from another site
  • translatable field icon now triggers a HUD, which contains a form that allows you to copy just that field’s value from the selected site;
    copy action is applied to the top-level fields (e.g. entire matrix field)
  • plugins need to implement CopyableFieldInterface to use this feature

IMPORTANT: once this feature is released, an update to craftcms/html-field needs to be released; craftcms/html-field#6

CleanShot.2023-12-19.at.13.44.44.mp4

i-just and others added 30 commits November 30, 2022 17:25
@i-just
POC for copying fields over (WIP)
ccaa6f3
@i-just
show notifications
e51cac0
@i-just
copy only top level fields
7dc40cf
@i-just
site select hooked up
3f2ce0c
@i-just
additional safeguards; adjust for title, slug; bug fixes
bfe9ff4
@i-just
Merge branch 'develop' into feature/979-copy-field-values-from-other-…
5784fa7 
…sites
@i-just
Merge branch '4.4' into feature/979-copy-field-values-from-other-sites
2456d85
@i-just
bug fix
74b215e
@i-just
copyable field interface added
870a6a5
@i-just
copy all element content; improve checks
d922efe
@i-just
bug fix and refactoring
f72bddc
@i-just
Merge branch 'develop' into feature/979-copy-field-values-v1
d33c140
@i-just
disclosure menu for selecting site to copy from
a5229ab
@i-just
styling improvement
d8f3fae
@brandonkelly
Merge branch '4.4' into feature/979-copy-field-values-v1
97910e2 
# Conflicts:
#	src/controllers/ElementsController.php
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
#	src/web/assets/cp/src/js/ElementEditor.js
@i-just
Merge branch '4.4' into feature/979-copy-field-values-v1
7db371e
@i-just
make translatable icon accessible via keyboard
6436864
@i-just
Merge remote-tracking branch 'origin/4.5' into feature/979-copy-field…
53454b8 
…-values-v1
@i-just
Merge branch '4.5' into feature/979-copy-field-values-v1
06575f5
@i-just
UI amends
c85950a
@i-just
Merge branch '5.0' into feature/979-copy-field-values-v1
b83ac89
@i-just
support for multi-instance fields
aa6caac
@i-just
WIP - close the hud and reload the page
939654f
@i-just
bug fixes
4512263
@i-just
Merge branch '5.0' into feature/979-copy-field-values-v1
761924f
@i-just
tweaks
38aaf79
@brianjhanson
Merge branch '5.0' of github.com:craftcms/cms into feature/979-copy-f…
fee2823 
…ield-values-v1
@i-just
Merge branch '5.0' into feature/979-copy-field-values-v1
71397bc
@i-just
copyable country field
282dc8b
@i-just
improved slideout handling + notices
5fd7d2f
i-just and others added 28 commits October 10, 2024 19:18
@i-just
empty value is still a value
7af7fb2
@i-just
ensure draft before copying the entire element too
fb60503
@i-just
build
ef78914
@i-just
Merge branch '5.5' into feature/cms-979-copy-field-values-from-other-…
ab4dd6a 
…sites
@i-just
back to Brian's namespacing, but with a twist
dea7ea6
@i-just
build
bb3fda6
@i-just
more namespacing changes
4435084
@i-just
Merge branch '5.5' into feature/cms-979-copy-field-values-from-other-…
43e98e3 
…sites
@i-just
Merge branch '5.5' into feature/cms-979-copy-field-values-from-other-…
ac4dccf 
…sites
@i-just
fixes for copy all accessibility issues
796f459
@i-just
change aria-role to role
9b498d8
@i-just
trigger field copy dialogue via keyboard
681948c
@i-just
build
77b20a6
@i-just
only create provisional draft first if we're about to copy field with…
28fabc4 
… nested entries
@i-just
build
79a633f
@i-just
announce loading/complete for filter hud
464f6ed
@brianjhanson
Move copy button to right side of field
f0580af
@brianjhanson
Handle aria-expanded for HUD
78741c6
@brianjhanson
Add modal heading
705f088
@brianjhanson
Add toggle via click
cc1c6de
@brianjhanson
Remove self-managed
7a44349
@brianjhanson
Meaningful label
2c65a82
@brianjhanson
Build
d99cbb5
@i-just
accessibility amends round 2
a7437b5
@i-just
don't show the icon if there's no sites to copy from & performance
b791847
@i-just
Merge branch '5.5' into feature/cms-979-copy-field-values-from-other-…
2d92601 
…sites
@brianjhanson
Keep tooltip open when hovering
6b25bff
@brianjhanson
Merge branch '5.5' of github.com:craftcms/cms into feature/cms-979-co…
c2b50d6 
…py-field-values-from-other-sites
@brianjhanson brianjhanson marked this pull request as ready for review November 4, 2024 15:33
@brandonkelly brandonkelly changed the base branch from 5.5 to 5.6 November 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brianjhanson @piotrpog @mmikkel @i-just @brandonkelly